Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix salvage mobs having ghost roles when they shouldn't #902

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

DebugOk
Copy link
Contributor

@DebugOk DebugOk commented Feb 26, 2024

About the PR

me when the

Changelog

🆑

  • fix: Space mobs no longer have ghost roles

@github-actions github-actions bot added the Changes: YML Changes any yml files label Feb 26, 2024
@IamVelcroboy
Copy link
Member

What why? This will totally mess up Arena

@DebugOk
Copy link
Contributor Author

DebugOk commented Feb 26, 2024

You'll have to make special entities for arena then, instead of replacing the mobs used for salvage

@DebugOk DebugOk linked an issue Feb 26, 2024 that may be closed by this pull request
@IamVelcroboy
Copy link
Member

I guess I misunderstood and thought this was reverting everything. Still wondering why we don't want ghost takeover on salvage mods though?

@deltanedas
Copy link
Member

they are always shitters

@IamVelcroboy
Copy link
Member

they are always shitters

Dang, shitters ruining everything I guess 😞

@DebugOk DebugOk merged commit 18a2b26 into master Feb 26, 2024
10 checks passed
@DebugOk DebugOk deleted the salvmobs branch February 26, 2024 20:20
DeltaV-Bot pushed a commit that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There are still salvage mobs with ghost roles
3 participants